基于C#的重构学习（一个完整的小例子）

      稍微对重构有所了解的人应该都知道有一本书叫《重构：改善既有代码设计》，这本由Martin Fowler写的巨著开启了重构新时代！不过有点可惜的是，也许是因为作者写这本书的时间太早，早到当时C#还不知道在哪！所以里面原生的实例全都是用java写的，虽说C#和java比较类似，但毕竟还是有区别的，看起来终归不是很舒服，就连Martin Fowler本人在书中也说希望今后能有人写一本C#版以及其他各种语言版本的重构书籍！本人也真心希望.Net版本的重构资料越来越多，不然我们学.Net要写论文，一查资料大部分都是java的资料，非常蛋疼！下面这个例子呢也是本人准备写小论文时找到的，拿出来分享下，这个例子虽然简单，但是做完了还真让人感觉确实重构技术很有意思啊，要是能将这门技术灵活掌握，今后开发软件势必获益匪浅！

　　这个例子是一个基于.Net平台的winform程序，功能比较简单，就是用来根据人的身高、体重还有年龄计算一个人每天应该摄入多少卡路里值，其次还可以算出一个人的完美体重，附带也算出当前真实体重与完美体重的差距，各位如果看了，千万请把注意力集中在里面的重构过程上而不是程序本身！下面是窗体截图：

：

闲话不多说，我把重构的几个版本代码都整理了下：关键是计算卡路里那个按钮的事件处理代码中含有长方法坏味道，我的重构呢也是想解决这个味道

 

#region 第一版源代码
      
            txtDistance.Text = "";
            txtIdeal.Text = "";
            txtRecommend.Text = "";

            double result;
            if (!double.TryParse(txtWeight.Text.Trim(), out result))
            {
                MessageBox.Show("请输入有效的体重值！");
                txtWeight.Select();
                return;
            }
            if (!double.TryParse(txtHeight.Text.Trim(), out result))
            {
                MessageBox.Show("请输入有效的身高值！");
                txtHeight.Select();
                return;
            }
            if (!double.TryParse(txtAge.Text.Trim(), out result))
            {
                MessageBox.Show("请输入合法的年龄值！");
                txtAge.Select();
                return;
            }
            if (!(Convert.ToDouble(txtHeight.Text.Trim()) >= 100))
            {
                MessageBox.Show("您输入的身高超出计算范围，请重新输入！");
                txtHeight.Select();
                return;
            }



            if (radioButtonMale.Checked)
            {
                double weight = Convert.ToDouble(txtWeight.Text.Trim());
                double height = Convert.ToDouble(txtHeight.Text.Trim());
                double age = Convert.ToDouble(txtAge.Text.Trim());
                double calories = DailyCaloryRecommendForMale(weight,height,age);
                txtRecommend.Text = Convert.ToString(calories);
                txtIdeal.Text = IdealWeightForMale(height).ToString();
            }
            else
            {
                double weight = Convert.ToDouble(txtWeight.Text.Trim());
                double height = Convert.ToDouble(txtHeight.Text.Trim());
                double age = Convert.ToDouble(txtAge.Text.Trim());
                double calories = DailyCaloryRecommendForFemale(weight,height,age);
                txtRecommend.Text = Convert.ToString(calories);
                txtIdeal.Text = IdealWeightForFemale(height).ToString();
            }
            //包含四个方法DailyCaloryRecommendForMale、DailyCaloryRecommendForFemale、IdealWeightForMale、IdealWeightForFemale、DistanceFromIdealWeight
            txtDistance.Text = DistanceFromIdealWeight(Convert.ToDouble(txtWeight.Text.Trim()), Convert.ToDouble(txtIdeal.Text.Trim())).ToString();
           
            #endregion

 

#region 第二版源代码 主要运用了Extract Method重构手法
         
            ClearResult();//封装了第一版三个清空文本框内容的代码
            if (!UserInputValid())//UserInputValid封装了对用户输入合法性验证的功能
            {
                return;
            }
            if (radioButtonMale.Checked)
            {
                double weight = Convert.ToDouble(txtWeight.Text.Trim());
                double height = Convert.ToDouble(txtHeight.Text.Trim());
                double age = Convert.ToDouble(txtAge.Text.Trim());
                double calories = DailyCaloryRecommendForMale(weight,height,age);
                txtRecommend.Text = Convert.ToString(calories);
                txtIdeal.Text = IdealWeightForMale(height).ToString();
            }
            else
            {
                double weight = Convert.ToDouble(txtWeight.Text.Trim());
                double height = Convert.ToDouble(txtHeight.Text.Trim());
                double age = Convert.ToDouble(txtAge.Text.Trim());
                double calories = DailyCaloryRecommendForFemale(weight,height,age);
                txtRecommend.Text = Convert.ToString(calories);
                txtIdeal.Text = IdealWeightForFemale(height).ToString();
            }
            txtDistance.Text = DistanceFromIdealWeight(Convert.ToDouble(txtWeight.Text.Trim()), Convert.ToDouble(txtIdeal.Text.Trim())).ToString();
           
            #endregion

 

#region 第三版源代码 运用了Extract Class、Move Method和Extract Method重构手法
        
            ClearResult();
            if (!UserInputValid())
            {
                return;
            }
            patient = new Patient();
            if (radioButtonMale.Checked)
            {
                patient.Gender = Gender.Male;
            }
            else
            {
                patient.Gender = Gender.Female;
            }
            patient.Height = Convert.ToDouble(txtHeight.Text.Trim());
            patient.Weight = Convert.ToDouble(txtWeight.Text.Trim());
            patient.Age = Convert.ToDouble(txtAge.Text.Trim());
            txtRecommend.Text = patient.DailyCaloryRecommend().ToString();
            txtIdeal.Text = patient.IdealWeight().ToString();
            txtDistance.Text = patient.DistanceFromIdealWeight().ToString();
           
            #endregion

 

 

 

 

#region 第四版源代码 运用了Extract Class和move method以及类的继承机制
        
            ClearResult();
            if (!UserInputValid())
            {
                return;
            }
            if (radioButtonMale.Checked)
            {
                patient = new MalePatient();
            }
            else
            {
                patient = new FemalePatient();
            }
            patient.Height = Convert.ToDouble(txtHeight.Text.Trim());
            patient.Weight = Convert.ToDouble(txtWeight.Text.Trim());
            patient.Age = Convert.ToDouble(txtAge.Text.Trim());

            txtRecommend.Text = patient.DailyCaloryRecommend().ToString();
            txtIdeal.Text = patient.IdealWeight().ToString();
            txtDistance.Text = patient.DistanceFromIdealWeight().ToString();
           
            #endregion

下面是经过重构提取的各种方法还有类

        private void ClearResult()
        {
            txtDistance.Text = "";
            txtIdeal.Text = "";
            txtRecommend.Text = "";
        }

        private bool UserInputValid()
        {
            double result;
            if (!double.TryParse(txtWeight.Text.Trim(), out result))
            {
                MessageBox.Show("请输入有效的体重值！");
                txtWeight.Select();
                return false;
            }
            if (!double.TryParse(txtHeight.Text.Trim(), out result))
            {
                MessageBox.Show("请输入有效的身高值！");
                txtHeight.Select();
                return false;
            }
            if (!double.TryParse(txtAge.Text.Trim(), out result))
            {
                MessageBox.Show("请输入合法的年龄值！");
                txtAge.Select();
                return false;
            }

            if (!(Convert.ToDouble(txtHeight.Text.Trim()) >= 100))
            {
                MessageBox.Show("您输入的身高超出计算范围，请重新输入！");
                txtHeight.Select();
                return false;
            }
            return true;
        }

        private double DistanceFromIdealWeight(double weight, double idealWeight)
        {
            return weight - idealWeight;
        }

        private double DailyCaloryRecommendForMale(double weight, double height, double age)
        {
            return 66 + 6 * weight + 13 * height - 7 * age;
        }

        private double DailyCaloryRecommendForFemale(double weight, double height, double age)
        {
            return 655 + 4 * weight + 5 * height - 5 * age;
        }

        private double IdealWeightForMale(double height)
        {
            return 50 + (height - 100) * 2;
        }

        private double IdealWeightForFemale(double height)
        {
            return 45 + (height - 100) * 2;
        }

public abstract class Patient
        {
            private string id;
            private string firstName;
            private string lastName;
            private double height;
            private double weight;
            private double age;

            //private Gender gender;

            public string Id
            {
                get { return this.id; }
                set { this.id = value; }
            }

            public string FirstName
            {
                get { return this.firstName; }
                set { this.firstName = value; }
            }

            public string LastName
            {
                get { return this.lastName; }
                set { this.lastName = value; }
            }

            public double Height
            {
                get { return this.height; }
                set { this.height = value; }
            }

            public double Weight
            {
                get { return this.weight; }
                set { this.weight = value; }
            }

            public double Age
            {
                get { return this.age; }
                set { this.age = value; }
            }

            /*
            public Gender Gender
            {
                get { return this.gender; }
                set { this.gender = value; }
            }*/


            public double DailyCaloryRecommendForMale()
            {
                return 66 + 6 * Weight + 13 * Height - 7 * Age;
            }

            public double DailyCaloryRecommendForFemale()
            {
                return 655 + 4 * Weight + 5 * Height - 5 * Age;
            }

            public double IdealWeightForMale()
            {
                return 50 + (Height - 100) * 2;
            }

            public double IdealWeightForFemale()
            {
                return 45 + (Height - 100) * 2;
            }

            public double DistanceFromIdealWeightForMale()
            {
                return Weight - IdealWeightForMale();
            }

            public double DistanceFromIdealWeightForFemale()
            {
                return Weight - IdealWeightForFemale();
            }

            public abstract double DistanceFromIdealWeight();//封装与具体性别相关的方法
            

            public abstract double DailyCaloryRecommend();//封装与具体性别相关的方法


            public abstract double IdealWeight();//封装与具体性别相关的方法
            

        }


        public class FemalePatient : Patient
        {
            public override double DailyCaloryRecommend()
            {
                return DailyCaloryRecommendForFemale();
            }

            public override double IdealWeight()
            {
                return IdealWeightForFemale();
            }

            public override double DistanceFromIdealWeight()
            {
                return DistanceFromIdealWeightForFemale();
            }

            
        }

        public class MalePatient : Patient
        {
            public override double DailyCaloryRecommend()
            {
                return DailyCaloryRecommendForMale();
            }

            public override double IdealWeight()
            {
                return IdealWeightForMale();
            }

            public override double DistanceFromIdealWeight()
            {
                return DistanceFromIdealWeightForMale();
            }
        }

正是上述这些提取出来的方法和类以及方法的移动才实现了按钮事件处理方法的极大优化，这样的优化能够显著提高程序的可维护性！其实里面各个版本程序的演变都是通过一步步重构实现的，具体还有些细节我没有展示完全，不过大家感兴趣可以通过现有给的最终代码逆推！